-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play Range start and end settings #4026
Comments
Thanks for the report. We will look into it. |
Thanks 👍 |
Hello, @joeyparrish Do we have any update on this bug? |
It looks like the UI is building off of player.seekRange(), but seekRange() is reported incorrectly: player.configure({playRangeStart: 10, playRangeEnd: 30});
player.seekRange()
{start: 10, end: 60} |
Looks like PresentationTimeline has a bug, and our unit test for seekRange() doesn't exercise this case. When the manifest parser notifies the timeline of explicit segment times, rather than just a range, the playRangeEnd is ignored. |
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed shaka-project#4026
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed shaka-project#4026
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed shaka-project#4026
Thanks for the quick workaround on this issue. I would also like to remind you that the UI build for DASH seems perfect but the video doesn't play at the start. For HLS, These settings are also applied for mp4 VOD rather than DASH and HLS? |
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed #4026
Please test again with the latest code from |
I created a playback issue #4091 the setting seems to be perfect for both HLS and DASH VOD but it gives playback problem |
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed #4026
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed #4026
For content where the manifest parser uses the notifySegments API (DASH SegmentBase/SegmentList/SegmentTimeline, or HLS, but not DASH SegmentTemplate+duration), the Player seekRangeEnd configuration was not being honored correctly. This fixes the issue in PresentationTimeline and adds a regression test to our playRangeStart/playRangeEnds tests. Fixed #4026
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v3.3.2
Can you reproduce the issue with our latest release version?
NO
Can you reproduce the issue with the latest code from
main
?NO
Are you using the demo app or your custom app?
Demo APP
If custom app, can you reproduce the issue using our demo app?
__
What browser and OS are you using?
Chrome, Firefox, safari edge on iOS, iPadOS, macOS, Linux, windows
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails.mpd
https://multiplatform-f.akamaihd.net/i/multi/will/bunny/big_buck_bunny_,640x360_400,640x360_700,640x360_1000,950x540_1500,.f4v.csmil/master.m3u8
What configuration are you using? What is the output of
player.getConfiguration()
?playRangeStart: 10,
playRangeEnd: 100
What did you do?
I try to set the start and end range for a VOD
What did you expect to happen?
To have a timeline same as start and end range declared
What happened?
When I try to apply the play range start and end for DASH, I have a perfect timeline UI with the range declared, but the video is stuck and doesn't play further unless I click the timeline it plays than when I take back the seek to the start it Stops again.
FOR HLS,
When we declare the range the UI is not well set up and when the video ends we are not able to play the video again.
For mp4, the settings are not applied.
Thanks
The text was updated successfully, but these errors were encountered: