Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix Russian translation #3751

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

Dador
Copy link
Contributor

@Dador Dador commented Nov 11, 2021

Description

Fixes for "On"/"Off"

Current Russian translation for "On" and "Off" are incorrect and misleading.

Current translation (Включить) for Off means Turn on.
Current translation (Отключить) for On means Turn off.

Current translation works in context of "Picture in picture", but completly incorrect in context of captions.

Is context of captions it looks like this:

(translation from Russian)
Captions:
- English
- Russian
- Turn on (but it's "Off" in original)

image

As you see, last item doing exactly opposite (turning subtitles off) of what Russian translation says.

New translations Выкл. for Off and Вкл. for On works in all cases. By the way, same spellings are used on popular video services such as YouTube:
image

Fix for "Captions"

Current translation (Титры) typically means credits at the start/end of the movie and it looks odd in that context. I changed translation to Субтитры (subtitles, closed captions). I know "subtitles" and "captions" are a bit different in English, but in Russian Субтитры are used for both cases. YouTube and other videos services also uses Субтитры (you can see it on the previous screenshot)

Fix for "Ad"

Current translation for Ad (Объявление) typically used about ads or announcements in newspapers or other paper mediums. It's rarely used in context of Internet Ads and especially in context of video ads. You typically see Реклама (new translation, means Ad, Advertising) in context of Internet Ads.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@joeyparrish
Copy link
Member

Thank you! We will need to push these translations back upstream into Google's internal translation system so they don't get overwritten the next time we sync with that system for new text or new languages. I've filed #3752 to track that.

@joeyparrish joeyparrish merged commit 3092063 into shaka-project:master Nov 11, 2021
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
Change-Id: I9012a988cece498a93625df0595064610fc6698b
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
Change-Id: Id9139af81b8fe5c2cc9549298866ec32be15ca23
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
Change-Id: I1c9eb3b6a877c9139ed7eb848ce7e54d7ee7126e
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants