Fix return from kws_raw_write on fragmented frame sending #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the last fragment sent
…issing spot in SSL block
…, but according to SSL lib 0 is an error so the behavior is slightly different using SSL versus not on the writing returns
…ns the error instead of the total written bytes
andywolk
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kws_raw_write should return the total number of bytes sent, not just the last fragment sent
Discussion with @andywolk concluded that we're still not comfortable with the condition and return here:
https://github.com/signalwire/libks/blob/master/src/kws.c#L1626
However, with the fix this will no longer be hit due to fragmented sending. I am leaving it to Andrey to follow up on what they want to do about that code acting as if it can handle partial returns when it cannot happen.