adding missing error handling

Signed-off-by: Ahmed Alsabag <ahmed.alsabag@gmail.com>
sigstore · Jun 6, 2024 · 0cfb306 · 0cfb306
1 parent 0f380d6
commit 0cfb306
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/internal/attest/attest_test.go b/internal/attest/attest_test.go
@@ -72,7 +72,10 @@ func TestAttestCommitRef(t *testing.T) {
 	name := "test.json"
 	content := readFile(t, filepath.Join("testdata/", name))
 
-	cfg, _ := gitsignconfig.Get()
+	cfg, err := gitsignconfig.Get()
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	attestor := NewAttestor(repo, sv, fakeRekor, cfg)
 

diff --git a/internal/utils.go b/internal/utils.go
@@ -39,6 +39,9 @@ func certFingerprint(cert *x509.Certificate) []byte {
 
 // StripURL returns the baseHost with the basePath given a full endpoint
 func StripURL(endpoint string) (string, string) {
-	u, _ := url.Parse(endpoint)
+	u, err := url.Parse(endpoint)
+	if err != nil {
+		return "", ""
+	}
 	return u.Host, u.Path
 }