Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup Ruby step in build job of verification workflow #4213

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Dec 2, 2020

As you can see in this run, the bundle command does not exists in the instance for ruby which executes the "Build Website" job. This is happening in all new pull requests because Github Actions now uses Ubuntu 20.04 specifying ubuntu-latest. I've been investigating this and seems that the action actions/setup-ruby is not maintained, with bugs in Ubuntu 20.04, and do not explicitly specify Bundler availability, so I've changed by ruby/setup-ruby action that seems better maintained, supports a lot of versions and explicitly declares Bundler availability.

Also, I've updated the Ruby version to 2.7 because Ruby v2.5 will reach their EOL at 2021-03-31.

@mondeja mondeja added the meta Issues or pull requests regarding the project or repository itself label Dec 2, 2020
This was referenced Dec 2, 2020
@fbernhart fbernhart mentioned this pull request Dec 2, 2020
3 tasks
@ericcornelissen
Copy link
Contributor

Oops... seems like I had too much fate in GitHub 😅 I'm very surprised actions/setup-ruby is already not being maintained any more, especially given that most of GitHub's infrastructure is build on Ruby!

Anyway, thanks for the investigation and quick fix @mondeja. I agree with your decision given the discussion in actions/setup-ruby#70, I'm also completely okay with updating to Ruby 2.7 - with Ruby I'm not as worried since it only builds our website and doesn't affect users of the packages.

And my apologies to everyone who experienced any difficulty due to this problem 😞

@ericcornelissen ericcornelissen merged commit 35c54c4 into simple-icons:develop Dec 2, 2020
@mondeja
Copy link
Member Author

mondeja commented Dec 2, 2020

And my apologies to everyone who experienced any difficulty due to this problem

I don't think it's your fault, I think that Github Actions is not well supported by the platform. Beyond this, I've seen this kind of lack of maintenance in many of the Github related repositories. Perhaps the most sensible thing to do is to stop trusting that "official" actions are the best.

@ericcornelissen
Copy link
Contributor

I don't think it's your fault, I think that Github Actions is not well supported by the platform. Beyond this, I've seen this kind of lack of maintenance in many of the Github related repositories. Perhaps the most sensible thing to do is to stop trusting that "official" actions are the best.

I'm afraid so... 😞

@mondeja mondeja deleted the up-ruby-action branch July 29, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants