-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rc1.3 review #118
Comments
@gkasprow thanks for the new rc. All looks good apart from the issues above. Mainly cosmetics apart from the switch capacitor and the Crms. |
Actually, @gkasprow one final though, but can you increase the 8dB attenuators on the output forward/reverse power detectors to 10dB. Otherwise, we may end up with a bit too much power at the detector due to component tolerances. |
@gkasprow We really don't have any more time for delays on this. The only non-cosmetic issues are:
FWIW Two of those three issues have been on the to do list for quite some time now, but seem to have been incorrectly ticked off during previous design reviews. Do you have time to do that all this morning? If not, I'm happy to fix it in Altium (it's only about 10min of work) and upload new designs for manufacture. |
I will do it immediately today and send files for production. I have a
meeting right now.
6 lis 2018 11:53 "hartytp" <notifications@github.com> napisał(a):
… @gkasprow <https://github.com/gkasprow> ping...are you okay to make those
changes so we can send the boards off to manufacture, or do you want me to?
Also, still waiting for confirmation that the following are fixed and can
be closed: #112 <#112> #111
<#111> #81
<#81> #57
<#57>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEH-vmtYzaqJbAu1_KcoP5FHBA5ws5RRks5usWomgaJpZM4YOWp0>
.
|
Thanks! |
Looks good, but don't forget to either add a termination resistor for the power detector or to adjust the value of one resistor to terminate correctly. |
sure :) |
all issues fixed, I placed new release |
Thanks Greg. A few comments:
|
OK, I changed the PN (ERJ-PA3F46R4V) but not the value displayed..
Ok, I mixed up power levels with attenuation.
OK, I didn't notice that. I removed another ones.
They were passed to mechanical team. I want to close them once I get final CAD files. |
Aah, makes sense! Thanks for fixing.
Well, it's a bit confusing since he has dB all over the design. The way I interpret it is that there is a fixed input power at the start of the pre-amp stage and then the dB values track that power through the schematic using the small-signal gain of each stage. So, the dB value of each stage is not the dB gain/loss of that stage, but rather the total gain/loss to the system after that stage, including all prior points. That's why the PA stage starts with +23dB and ends at +38dB. To be consistent with this, the dB value after the attenuator should be 38dB (output power) - 20dB (coupler) - 10dB (attenuator) = 8dB. |
Good idea. |
So, it looks like we can close this issue and begin manufacture. Many thanks Greg!!! |
The text was updated successfully, but these errors were encountered: