Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to use this library to generate PIN numbers, which users must type on a numeric keypad (a separate hardware device). As it stands, we would need to use:
everywhere we do this.
My concern about this approach is it's easy to accidentally delete one character in the character set, and we'd end up with something like:
Which at a glance you wouldn't notice is not actually the full numeric set and exponentially decreases the security of the generated PINs. I'd prefer to do:
As this seems more readable to me, as well as throwing an error at runtime if it's subtly broken instead of just silently becoming less secure. We also use Typescript, so we'd see the error in the
type
option immediately as well.Edit: I also fixed a typo in a comment, forgot to mention that.