Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from the silver searcher to ripgrep #738

Merged
merged 4 commits into from
May 30, 2017

Conversation

stevenbarragan
Copy link
Contributor

ripgrep is faster than {grep, ag, git grep, ucg, pt, sift}.

check this blog post.

@lfilho
Copy link
Collaborator

lfilho commented Feb 21, 2017

@skwp this seems super nice. Any thoughts?

@stevenbarragan the branch has conflicts now :/

@stevenbarragan
Copy link
Contributor Author

@lfilho merge conflicts fixed.

@stevenbarragan
Copy link
Contributor Author

@skwp any thoughts about this PR? or maybe you need some help maintaining the repo? I've seen some PR's stay open for ever

@skwp
Copy link
Owner

skwp commented May 23, 2017

Sorry guys, I've really been unable to do a good job maintaining. I'm revisiting the PRs

@skwp
Copy link
Owner

skwp commented May 23, 2017

My main issue with this it will break a lot of people who don't have it brew installed and just pull on the repo. Why not provide this as a new mapping ,rg?

" Use rg in CtrlP for listing files. Lightning fast and respects .gitignore
let g:ctrlp_user_command = 'rg --files --smart-case %s'

" rg is fast enough that CtrlP doesn't need to cache
let g:ctrlp_use_caching = 0
else
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would do a fallback to ag here

@stevenbarragan
Copy link
Contributor Author

@skwp I added the fall back to ag, and I added the mapping ,rg in here.

@templeman
Copy link

Also worth noting that ag.vim has been deprecated: rking/ag.vim#124 (comment).

@lfilho
Copy link
Collaborator

lfilho commented May 29, 2017

Speaking of backwards compatibilities, should we try to avoid key mappings too specific for plugins? For example, instead of ,ag and ,rg, why not have only something like ,fa (find in all) or ,fe (find everywhere) or whatever?

This way we would be less dependent and coupled with which plugins provide certain features...

@skwp
Copy link
Owner

skwp commented May 30, 2017

We do have a generic mapping of ,gg also (go grep, git grep, or whatever mnemonic you like there)

@skwp skwp merged commit 0f1683c into skwp:master May 30, 2017
@skwp
Copy link
Owner

skwp commented May 30, 2017

Sorry guys I had to revert, it turns out ripgrep doesn't install cleanly on my machine. It tried to compile but failed. Until I understand that I dont' want to break other people

@skwp
Copy link
Owner

skwp commented May 30, 2017

configure: error: in `/private/tmp/rust-20170530-4679-511zir/rustc-1.17.0-src/build/x86_64-apple-darwin/native/jemalloc':
configure: error: C compiler cannot create executables
See `config.log' for more details

Build failed, waiting for other jobs to finish...
error: build failed


command did not execute successfully: "/private/tmp/rust-20170530-4679-511zir/rustc-1.17.0-src/build/x86_64-apple-darwin/stage0/bin/cargo" "build" "-j" "8" "--target" "x86_64-apple-darwin" "--release" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/private/tmp/rust-20170530-4679-511zir/rustc-1.17.0-src/src/libstd/Cargo.toml"
expected success, got: exit code: 101

@lfilho
Copy link
Collaborator

lfilho commented May 30, 2017 via email

@stevenbarragan
Copy link
Contributor Author

I'm sorry about that, I didn't have any issue either, I'll take a look.

@lfilho
Copy link
Collaborator

lfilho commented May 31, 2017

@skwp sanity check: have you update your brew recently?

I'm running brew 1.2.1, OSX El Capitan and zsh 5.3.1

@lfilho
Copy link
Collaborator

lfilho commented Jun 5, 2017

@stevenbarragan and @skwp did you have a chance to have a look? I think this PR will greatly speed things for everyone in #661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants