Fix redundant newlines when pasting from external sources (#4050)

slab · Mar 14, 2024 · 71fada2 · 71fada2
1 parent 80f22d8
commit 71fada2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 - Fix `Quill#getSemanticHTML()` for list items
 - Remove unnecessary Firefox workaround
+- **Clipboard** Fix redundant newlines when pasting from external sources
 
 # 2.0.0-rc.2
 

diff --git a/packages/quill/src/modules/clipboard.ts b/packages/quill/src/modules/clipboard.ts
@@ -529,7 +529,10 @@ function matchList(node: Node, delta: Delta, scroll: ScrollBlot) {
 
 function matchNewline(node: Node, delta: Delta, scroll: ScrollBlot) {
   if (!deltaEndsWith(delta, '\n')) {
-    if (isLine(node, scroll)) {
+    if (
+      isLine(node, scroll) &&
+      (node.childNodes.length > 0 || node instanceof HTMLParagraphElement)
+    ) {
       return delta.insert('\n');
     }
     if (delta.length() > 0 && node.nextSibling) {

diff --git a/packages/quill/test/unit/modules/clipboard.spec.ts b/packages/quill/test/unit/modules/clipboard.spec.ts
@@ -563,5 +563,11 @@ describe('Clipboard', () => {
           .insert('\n'),
       );
     });
+
+    test('ignore empty elements except paragraphs', () => {
+      const html = '<div>hello<div></div>my<p></p>world</div>';
+      const delta = createClipboard().convert({ html });
+      expect(delta).toEqual(new Delta().insert('hello\nmy\n\nworld'));
+    });
   });
 });