image selector fix #4120
Merged
image selector fix #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I added a commit to fix some failing tests. Can you take a look? |
|
Hi @luin , It's good, thanks so much. |
luin
approved these changes
Apr 19, 2024
ut4
added a commit
to sivujetti/sivujetti
that referenced
this pull request
May 6, 2024
`quill-customizations.js` (fixed in slab/quill#4120).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as we see on the v2 web site, theme toolbar's handlers (like image) are overwritten, and quill uses the default handler instead.
The fix : quill.ts, "special case toolbar shortend" was called too late.
We can also see this difference in the code between v2.0 and v1.3.7
Thanks,