Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the not hex color doesn't change in toolbar #4139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zzxming
Copy link

@zzxming zzxming commented Apr 25, 2024

I found that when actively transmitting color values, only the hex color value will change along with the cursor movement on the toolbar, while other color values will remain in the default state.
I found that when getting element attributes, color values are automatically converted to RGB color values. So I did the change below

Added a function to convert existing color values in base.ts.
Added color conversion in toolbar.ts to handle user arguments color.
Delete color and background internal processing.

After processing, all reasonable values that can be placed on the element can be processed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant