Improvements to Polyline #1022
Merged
Improvements to Polyline #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to add arrows to start, end, mid-points, and to swap direction of midpoint arrows. This functionality is similar to what PyDMDrawingLine already has added.
nstelter-slac
force-pushed
the
polyline_arrows
branch
from
6bdc2db
to
c4f9ca9
Compare
-Add update button, saves and applies changes to settings without closing the settings-editor window -Add ability to swap point ordering in settings-editor by drag and drop
nstelter-slac
force-pushed
the
polyline_arrows
branch
from
6623541
to
5f4441f
Compare
nstelter-slac
force-pushed
the
polyline_arrows
branch
2 times, most recently
from
6a93f71
to
25cf7f7
Compare
Also: -minor change to member variable name to be more consistent. -minor change to comments
nstelter-slac
force-pushed
the
polyline_arrows
branch
from
25cf7f7
to
45a80a2
Compare
jbellister-slac
approved these changes
Aug 29, 2023
YektaY
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #962
To try out changse:
-pydm examples/drawing/drawing_demo.ui
-"File", then "Open in Designer"
-click on polyline widget, below label "PyDMDrawingPolyline" (bottom right of qt window)
-go right-side of window in property window, and scroll to bottom to find polyline specific settings
-can toggle on/off the arrow options, and see reflected in qt designer
Fixes #964
To try out changes:
-pydm examples/drawing/drawing_demo.ui
-"File", then "Open in Designer"
-double click on polyline widget, below label "PyDMDrawingPolyline" (bottom right of qt window)
-can edit points by double clicking on a point and typing new value, press "Update" in bottom right of settings
window, and can see polyline widget's points get updated according
-can rearrange points by clicking and dragging one point over the other, and see that they have swapped positions