Basic version of multi-state LED indicator widget #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
changed the title
|
I think since this is a new widget, it will be need to be included in the documentation |
klauer
reviewed
Oct 27, 2023
|
|
||
| # color state setters/getters | ||
| @Property(QColor) | ||
| def state0Color(self) -> QColor: |
There was a problem hiding this comment.
A random thought, for your consideration...
Seeing this sort of stuff makes me wonder if having a channelValue Qt property that mirrors the current value of the channel might be something to explore.
I mention that because you can use Qt stylesheets / qss to have property selectors and change any bit of styling as you please, rather than just being limited to color (even if that is technically sufficient for what's being asked here).
So you could imagine:
PyDMMultiStateIndicator[currentValue="1"] #something {
qproperty-penColor: black;
qproperty-setsomething: foobar;
}
We use this method in our vacuum screen widgets, by the way (ref)
…t value of widget's connected channel
jbellister-slac
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic version of widget.
could expand out later with:
-submenu for easier selection of state colors
-options for rendering different shapes/visual
-accepting >1 PVs
-allow configurable # states besides just 16