-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Cleanup drawing lines class-structure #1073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
changed the title
Cleanup drawing lines class-structure
MNT: Cleanup drawing lines class-structure
Apr 11, 2024
nstelter-slac
force-pushed
the
cleanup_line_drawing
branch
from
April 11, 2024 19:19
1c50e4d
to
101a07e
Compare
nstelter-slac
force-pushed
the
cleanup_line_drawing
branch
2 times, most recently
from
May 1, 2024 20:22
deb40ef
to
21366cc
Compare
nstelter-slac
force-pushed
the
cleanup_line_drawing
branch
from
May 1, 2024 20:25
21366cc
to
c77d28a
Compare
YektaY
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update looks good, my only comments are with adding type hints.
Edit:
I have found a bug that crashes Designer. if you create a PyDMDrawingLine and then edit the arrow properties, before adding points, then designer will crash
YektaY
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #1072
move shared code between line and polyline into base class, removes redundant code
also move polyline class up in file, so is right after line class (for easier reference imo)