Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Cleanup drawing lines class-structure #1073

Merged
merged 6 commits into from
May 6, 2024

Conversation

nstelter-slac
Copy link
Collaborator

@nstelter-slac nstelter-slac commented Apr 11, 2024

followup to #1072

move shared code between line and polyline into base class, removes redundant code

also move polyline class up in file, so is right after line class (for easier reference imo)

@nstelter-slac nstelter-slac changed the title Cleanup drawing lines class-structure MNT: Cleanup drawing lines class-structure Apr 11, 2024
@nstelter-slac nstelter-slac marked this pull request as ready for review April 11, 2024 19:21
@YektaY YektaY self-requested a review April 12, 2024 21:25
@nstelter-slac nstelter-slac force-pushed the cleanup_line_drawing branch 2 times, most recently from deb40ef to 21366cc Compare May 1, 2024 20:22
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update looks good, my only comments are with adding type hints.

Edit:

I have found a bug that crashes Designer. if you create a PyDMDrawingLine and then edit the arrow properties, before adding points, then designer will crash

pydm/widgets/drawing.py Outdated Show resolved Hide resolved
pydm/widgets/drawing.py Outdated Show resolved Hide resolved
pydm/widgets/drawing.py Outdated Show resolved Hide resolved
pydm/widgets/drawing.py Outdated Show resolved Hide resolved
@YektaY YektaY merged commit 715e7f8 into slaclab:master May 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants