ENH: Axis labels show which curves are on the axis #1099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksharsarvesh
force-pushed
the
axisLabels
branch
from
27cea1f
to
619790b
Compare
aksharsarvesh
force-pushed
the
axisLabels
branch
from
619790b
to
c4da094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1097, because it requires the use of the _curves attribute added to BasePlotAxisItems in that PR.
Given that each axis can have many curves on it, and you can freely move curves around, it can be confusing which curves are attached to which axes. As such, users will want to see which curves are attached to which axes.
Every time a curve is linked, unlinked, or its name changes, we are calling autoVisible to make sure the axis should or should not be shown. As a subroutine, we edit the label to include the names of the curves attached to this axis. If it is to be shown, the label will be updated; if not, it will remain hidden anyway.