FIX: Switching Y Axis orientation was not properly updating #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
approved these changes
Aug 7, 2024
YektaY
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the axis table model, when switching an axis from left to right orientation, it was not actually moving the axis. There is a function in multi_plot_axis.py called "rebuildLayout" that moves the axes to where they need to be in the layout, which is one of the added lines.
The axis would then be physically moved, but it would also require being flipped around such that the label would be on the right side of the axis, which wasn't being done either. Prompting the axis to show causes it to redraw properly, so now by switching orientation of a y-axis from left to right (or vice versa) will correctly and immediately update the axis to the opposite side.