Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bare links in docs against Rust 1.53 #563

Closed
wants to merge 1 commit into from

Conversation

jdisanti
Copy link
Collaborator

Rust 1.53 added a lint for bare URLs: rust-lang/rust#81764

This PR fixes doc generation so that docs continue to build with the latest stable compiler, but does not attempt to be the long-term documentation normalization strategy.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh
Copy link
Collaborator

rcoh commented Jun 29, 2021

would be nice to have a generated code diff to audit

@jdisanti
Copy link
Collaborator Author

On second thought, there isn't really a good way to fix this without full parsing of the documentation. There are cases in the documentation such as this that should not get transformed:

<code>curl
http://someurl</code>

Or

<code>[ "CMD-SHELL", "curl -f http://localhost/ || exit 1" ]</code>

I'll table this and start on the long-term approach.

@jdisanti jdisanti closed this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants