Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use parking_lot #2

Closed
wants to merge 1 commit into from
Closed

use parking_lot #2

wants to merge 1 commit into from

Conversation

cssivision
Copy link

No description provided.

@ghost
Copy link

ghost commented Sep 28, 2020

Are there any significant improvements in benchmarks? I feel hesitant about adding a new dependency if not.

@raftario
Copy link

Could this be made into an optional feature while defaulting to the standard library ?

@raftario
Copy link

As of performance improvements, the main one is that parking_lot::Condvar is a lot cheaper to create compared to std::sync::Condvar cause the latter allocates.

@taiki-e
Copy link
Collaborator

taiki-e commented Feb 4, 2021

I'm okay with adding this as an optional feature, but I'd like to know how much this actually improves performance before merging. (I know parking_lot is basically faster than std, but switching to it doesn't necessarily help improve overall performance.)

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 30, 2022

Closing -- std mutex enough fast since rust-lang/rust#95035

@taiki-e taiki-e closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants