Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcpv4: use offered ip in requested ip option #310

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

MabezDev
Copy link
Contributor

@MabezDev MabezDev commented Oct 7, 2019

Instead of configuring the ifaces ip address when a dhcp server offers
and ip, the client now use the requested_ip dhcp option, based on the offered ip
(yiaddr). The user now only has to configure the iface once the dhcp
transaction has completed (Ack'd).

Closes #302.

cc: @astro

Instead of configuring the ifaces ip address when a dhcp server offers
and ip, we now use the requested_ip option, based on the offered ip
(yiaddr). The user now only has to configure the iface once the dhcp
transaction has completed (Ack'd).
@MabezDev
Copy link
Contributor Author

MabezDev commented Jan 4, 2020

@whitequark would it be possible to squeeze this in be fore the next release? Not sure who's best to review this as @astro is busy atm I think.

@whitequark
Copy link
Contributor

Okay, I'll review it before that.

src/dhcp/clientv4.rs Outdated Show resolved Hide resolved
@MabezDev
Copy link
Contributor Author

@whitequark I see this didn't make it into 0.6 :(, Will this now have to wait till 0.7 or could it make it into a patch release? (I don't think this is breaking change)

@whitequark
Copy link
Contributor

We can make a patch release just fine. I was just really low on time lately--as soon as I review this, I can cut a release for you.

@MabezDev
Copy link
Contributor Author

Thanks. I appreciate the time you've taken to review my PR's thus far. Let me know if there is anything I can do to help.

@whitequark whitequark merged commit 0a967c5 into smoltcp-rs:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DHCP: is setting address before ACKed ok?
3 participants