Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra padding inserted when using data-container="body" #463

Closed
MartyBJones opened this issue Jan 26, 2014 · 7 comments
Closed

extra padding inserted when using data-container="body" #463

MartyBJones opened this issue Jan 26, 2014 · 7 comments
Milestone

Comments

@MartyBJones
Copy link

I noticed that if i set data-container="body" that I get extra vertical padding from the select and the available options. I did a search and found a issue that mentioned this very thing (#348). The issue was closed and is supposed to be fixed as of version 1.3.5. I am running version 1.4.3.

Do you think this may be a regression bug? The screen shots on issue #348 show the exact thing I am seeting.

Any ideas?

@caseyjhol
Copy link
Member

Good catch - will be fixed in the next update.

You can fix this in the meantime by changing line 381 to:

$drop.addClass($element.attr('class').replace(/form-control/gi, '')).toggleClass('dropup', $element.hasClass('dropup'));

or by removing the form-control class and adding data-width="100%" to the select.

@MartyBJones
Copy link
Author

Casey,

I updated the js at the line you provided and all is good now!

Thanks for the quick response.

Marty

On Mon, Jan 27, 2014 at 2:11 AM, caseyjhol notifications@github.com wrote:

Good catch - will be fixed in the next update.

You can fix this in the meantime by changing line 381 to:

$drop.addClass($element.attr('class').replace(/form-control/gi, '')).toggleClass('dropup', $element.hasClass('dropup'));

or by removing the form-control class and adding data-width="100%" to the
select.

Reply to this email directly or view it on GitHubhttps://github.com//issues/463#issuecomment-33348132
.

@MartyBJones
Copy link
Author

Casey,

One more question, Is it possible to use bootstrap-select within an input
append? I would like to use a input control group that has a text input
field at the beginning with a bootstrap-select appended to the end. So the
control would let users enter in a number and the select would let them
qualify what the number represents such as "thousands", "milliions" etc.

Marty

On Mon, Jan 27, 2014 at 8:42 AM, Marty Jones martybjones@gmail.com wrote:

Casey,

I updated the js at the line you provided and all is good now!

Thanks for the quick response.

Marty

On Mon, Jan 27, 2014 at 2:11 AM, caseyjhol notifications@github.mirror.nvdadr.comwrote:

Good catch - will be fixed in the next update.

You can fix this in the meantime by changing line 381 to:

$drop.addClass($element.attr('class').replace(/form-control/gi, '')).toggleClass('dropup', $element.hasClass('dropup'));

or by removing the form-control class and adding data-width="100%" to
the select.


Reply to this email directly or view it on GitHubhttps://github.com//issues/463#issuecomment-33348132
.

@caseyjhol
Copy link
Member

Will be including this feature in 1.5.0. It already exists for Bootstrap 2.3.2, but the method was changed in Bootstrap 3.

@Luigi-Pampaloni
Copy link

Hi guys, version 1.5.4 seems to suffer from the same problem... is it possible to have a look ?
Regards

@caseyjhol
Copy link
Member

I can't reproduce the problem with 1.5.4. Any more info?

@Luigi-Pampaloni
Copy link

Hi caseyjhol,

Thanks for getting me back.

The page structure is quite complex not sure how to provide more info.
I have attached a screenshot to show the extra padding added and below the
fragment of the generated html that I can see. Not sure if is useful.

Dr. John SmithDr. Alex Jones
Dr. John Smith 
</div>

If the details provided are not enough to understand where the problem is
let me know what can I do to support you.

Thanks for the great job you¹ve done !

Luigi

From: caseyjhol notifications@github.com
Reply-To: silviomoreto/bootstrap-select
<reply+i-26308595-df2fcafa4b7ab89389741a72aef08ac663ec1996-7968225@reply.git
hub.com>
Date: Thursday, 26 June 2014 23:09
To: silviomoreto/bootstrap-select bootstrap-select@noreply.github.com
Cc: Luigi Pampaloni luigi_pampaloni@hotmail.com
Subject: Re: [bootstrap-select] extra padding inserted when using
data-container="body" (#463)

I can't reproduce the problem with 1.5.4. Any more info?


Reply to this email directly or view it on GitHub
<#463 (comment)
286582> .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants