Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated / for division by calc function call #2777

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

guustnieuwenhuis
Copy link

fix for:
#2749

branched of v1.13.18

Copy link
Collaborator

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this has been adressed already. Apparently not, thank you!

@NicolasCARPi
Copy link
Collaborator

Oh yeah, it was adressed, look at the conflict!

@NicolasCARPi
Copy link
Collaborator

Oh okay I see you branched of stable.... This will be a release decision to be taken by @caseyjhol if he wants to have this.

Copy link
Collaborator

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my approval as it conflicts.

@guustnieuwenhuis
Copy link
Author

We were hoping a patch release could be created on 1.13

@PikachuEXE
Copy link

Still no update?
Or is it because there is no branch for 1.13?

@NicolasCARPi
Copy link
Collaborator

Still no update?

@PikachuEXE #2228 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants