Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Churn Buster #152

Merged
merged 6 commits into from
Oct 10, 2020
Merged

Integrate Churn Buster #152

merged 6 commits into from
Oct 10, 2020

Conversation

aldesantis
Copy link
Member

@aldesantis aldesantis commented Sep 30, 2020 •
edited
Loading

Integrates Churn Buster natively in the extension, starting and stopping campaigns as a subscription fails/succeeds payment.

@aldesantis aldesantis force-pushed the aldesantis/churn-buster branch 5 times, most recently from 8432d09 to 730184a Compare October 1, 2020 12:59
@aldesantis aldesantis self-assigned this Oct 1, 2020
@aldesantis aldesantis added the enhancement Improves an existing feature. label Oct 1, 2020
@aldesantis aldesantis force-pushed the aldesantis/churn-buster branch 11 times, most recently from 8846f57 to 6ab8662 Compare October 8, 2020 11:49
kennyadsl
kennyadsl reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions + I'd add a note in the README, seems pretty important, especially for the business value this brings. Great work!

spec/lib/solidus_subscriptions/churn_buster_spec.rb Outdated Show resolved Hide resolved
lib/solidus_subscriptions/churn_buster.rb Outdated Show resolved Hide resolved
@aldesantis aldesantis force-pushed the aldesantis/churn-buster branch 2 times, most recently from daa1b6f to 8258965 Compare October 9, 2020 12:43
@aldesantis aldesantis merged commit 6b5c54f into master Oct 10, 2020
@aldesantis aldesantis deleted the aldesantis/churn-buster branch October 10, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@aldesantis aldesantis

Labels
enhancement Improves an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldesantis @kennyadsl