Improve promotion rules names #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for naming the models in a way more consistent to Solidus (which doesn't include "PromotionRule" in the name of the class). Also, it easily allows for the promotion rules to be displayed with a better name in the admin panel (which just uses the promotions model name humanized).
This displays a correct description in the admin panel
aldesantis
approved these changes
Mar 22, 2021
luca-landa
added a commit
that referenced
this pull request
Mar 23, 2021
After #215 update promotion rule names on db to avoid STI errors.
luca-landa
added a commit
that referenced
this pull request
Mar 25, 2021
After #215 update promotion rule names on db to avoid STI errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #205
I renamed the promotion rules, so that they should be easier to understand both by developers and admin users without more documentation (if you have better names in mind, suggestions are welcome!)
Also, I changed the models paths in a way more consistent to solidus, but I left this refactor in a separate commit since I don't know if there are reasons not to do it that I'm missing.
Anyway, this allowed the deletion of "PromotionRule" from models class names. Since the admin panel always displays their model name humanized as a title (and I found no way around that works), this appeared the only reasonable way to improve their title in the admin panel.