Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create order finalized subscriber/job for subscription creation #261

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Create order finalized subscriber/job for subscription creation #261

merged 1 commit into from
Aug 10, 2022

Conversation

FrancescoAiello01
Copy link
Collaborator

@FrancescoAiello01 FrancescoAiello01 commented Aug 8, 2022 •
edited
Loading

Resolves #260

Stop decorating the order#finalize! method to create subscriptions and instead create subscriptions as part of a background job.

@FrancescoAiello01 FrancescoAiello01 force-pushed the faiello/stop-decorating-order-finalize branch 5 times, most recently from c0a8754 to 6b87790 Compare August 9, 2022 17:58
@FrancescoAiello01 FrancescoAiello01 force-pushed the faiello/stop-decorating-order-finalize branch from 6b87790 to 9935d29 Compare August 9, 2022 17:59
@FrancescoAiello01 FrancescoAiello01 marked this pull request as ready for review August 9, 2022 18:22
@FrancescoAiello01
Copy link
Collaborator Author

@kennyadsl @elia

@elia elia self-requested a review August 10, 2022 07:43
@kennyadsl
Copy link
Member

@FrancescoAiello01 Thanks, this looks great. I saw that tests on this extension are not running against Solidus master branch. I think it's because of eefdc5f, which has not been reverted. It would be great if we could restore it, even with another PR so that we are sure we merge something that works with the last version of Solidus (3.2), which will be released soon.

Thanks!

@elia
Copy link
Member

elia commented Aug 10, 2022 •
edited
Loading

@FrancescoAiello01 Thanks, this looks great. I saw that tests on this extension are not running against Solidus master branch. I think it's because of eefdc5f, which has not been reverted. It would be great if we could restore it, even with another PR so that we are sure we merge something that works with the last version of Solidus (3.2), which will be released soon.

Thanks!

@kennyadsl I'll take care of that 👍

@elia elia merged commit e13e11f into solidusio:master Aug 10, 2022
@elia elia mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop decorating order#finalize! to create subscriptions
3 participants
@FrancescoAiello01 @kennyadsl @elia