Small UI change to canceling in the admin #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2017 19:58
This was previously a "pause" icon. I think canceling a subscription should seem more substantial than a pause, but less substantial than a delete. Stop makes more sense to me. The activation is also a play button, so stop also makes more sense to me.
Canceling isn't destructive per se, but it seems like a large enough change to a subscription that I want to double check with the user. This also follows canceling an order in the Solidus admin (which can also be resumed).
qr8r
approved these changes
Aug 11, 2017
|
Awesome!! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always felt off that the cancel button was a "pause" icon and happened without confirmation. This updates it to be a "stop" icon (restarting is a "play" icon), which seems to be the right level of destructive to me. More than pause, less than trash can.
Also adds a confirmation dialog. Although the subscription can easily be restarted, it's conceivable that a store hooks in a cancelation email and it would be nice to double check that they actually want to cancel. This also follows the Solidus Orders admin, which confirms via a dialog (it can also be restarted).
This is all very much just opinion.