Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform/sfp] Add test cases for SFP error status #3648

Merged
merged 4 commits into from
Jun 30, 2021
Merged

[platform/sfp] Add test cases for SFP error status #3648

merged 4 commits into from
Jun 30, 2021

Commits on Jun 8, 2021

  1. Add test cases for SFP error status 

    - Add test cases for sfputil show error-status
- Add platform test for SFP.get_error_description()

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    3282368 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Address comments 

    - Remove unused variable
- Simplify the fixture of the command

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    79d1985 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Address the comment: move test_sfp_error_status to the SFP section 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    94bff70 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Fix review comments 

    - Skip the test if error status isn't supported
- Skip the test on versions 202012, 201911, 201811
- Add comments

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    0a3e781 View commit details
    Browse the repository at this point in the history