Potential fix for timing issue in warm_reboot's routing UT #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made to 201811 branch on 2/14/2019 (cherry-pick in case we need to pick future changes in warm reboot test). |
yxieca
pushed a commit
that referenced
this pull request
Feb 14, 2019
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
If ACL table name contains the substring "v6", set the EtherType of the rule to V6, otherwise set to V4.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
avoid to use publish build artifacts and pipeline artifacts at the same time. Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal with this one is to reactivate the unit-tests written as part of the routing warm-reboot effort. There seems to be a timing issue behind the sporadic failure seen during the execution of Testcase-15. I'm adjusting the restart_timer value that i'm using in these testcases to see if that fixes the issue. Notice that i'm unable to reproduce this problem in my testbed, so i'm hoping to be able to run various jenkin's testing-cycles before merging this PR.