Skip to content

Commit

Permalink
Upgrade workflows to actions/checkout@v4, actions/upload-artifact@v4,…
Browse files Browse the repository at this point in the history
  • Loading branch information
sophimao committed Jun 20, 2024
1 parent 3055280 commit 124f56b
Show file tree
Hide file tree
Showing 10 changed files with 27 additions and 31 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:

steps:
- name: checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: query distribution
run: cat /etc/os-release
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
- name: upload binary package
if: github.event_name == 'push'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: fpga-runtime-for-opencl-${{ github.sha }}-${{ matrix.image }}-${{ matrix.config }}-${{ github.run_id }}
path: /fpga-runtime-for-opencl
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
manifests: cmake/manifests/linux

- name: upload manifests if installed components changed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: manifests-${{ matrix.image }}-${{ matrix.config }}-${{ github.run_id }}
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

steps:
- name: checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: query path of compiler setup script
id: msvc
Expand All @@ -74,7 +74,7 @@ jobs:
- name: cache libelf
id: cache-libelf
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: c:\libelf
key: libelf-${{ hashFiles('.github/workflows/build-windows.yml', 'scripts/install_libelf.ps1') }}
Expand All @@ -91,7 +91,7 @@ jobs:

- name: cache zlib
id: cache-zlib
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: c:\zlib
key: zlib-${{ hashFiles('.github/workflows/build-windows.yml', 'scripts/install_zlib.ps1') }}
Expand All @@ -108,7 +108,7 @@ jobs:

- name: cache ninja
id: cache-ninja
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: c:\ninja
key: ninja-${{ hashFiles('.github/workflows/build-windows.yml', 'scripts/install_ninja.ps1') }}
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:
- name: cache aocl
id: cache-aocl
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: c:\aocl
key: aocl-${{ hashFiles('.github/workflows/build-windows.yml', 'scripts/install_aocl.ps1') }}
Expand All @@ -172,7 +172,7 @@ jobs:
- name: upload binary package
if: github.event_name == 'push'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: fpga-runtime-for-opencl-${{ github.sha }}-${{ matrix.image }}-${{ matrix.config }}-${{ github.run_id }}
path: c:\fpga-runtime-for-opencl
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
manifests: cmake\manifests\windows

- name: upload manifests if installed components changed
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: manifests-${{ matrix.image }}-${{ matrix.config }}-${{ github.run_id }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

steps:
- name: checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: run clang-format on source files
run: ./scripts/clang-format.sh --verbose
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:

steps:
- name: checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

# https://docs.docker.com/engine/reference/commandline/tag/#extended-description
# > A tag name must be valid ASCII and may contain lowercase and
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:

steps:
- name: checkout main branch
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.base_ref }}

Expand All @@ -55,7 +55,7 @@ jobs:
run: mv -t "$RUNNER_TEMP" build

- name: checkout current branch
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: create build directory
run: mkdir build
Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/coverity-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

steps:
- name: Checkout PR
uses: actions/checkout@v3
uses: actions/checkout@v4
- run: echo /opt/coverity/latest/bin >> "$GITHUB_PATH"
- name: Build current
run: |
Expand Down Expand Up @@ -77,17 +77,13 @@ jobs:
cov-format-errors --text-output-style multiline --dir results --filesort --file "$(realpath ..)" --strip-path "$(realpath ..)" > ../cov-errors-base.txt
cd ..
readlink -f cov-errors-base.txt
- name: Upload current cov-errors.txt
uses: actions/upload-artifact@v3
- name: Upload current and base cov-errors
uses: actions/upload-artifact@v4
with:
name: fpga-runtime-for-opencl-${{ github.sha }}-coverity-${{ github.run_id }}
path: cov-errors.txt
if-no-files-found: error
- name: Upload base cov-errors.txt
uses: actions/upload-artifact@v3
with:
name: fpga-runtime-for-opencl-${{ github.sha }}-coverity-${{ github.run_id }}
path: cov-errors-base.txt
path: |
cov-errors.txt
cov-errors-base.txt
if-no-files-found: error
- name: Verify no new Coverity Issues
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coverity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- /opt/coverity:/opt/coverity

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- run: cmake -G Ninja -S . -B build -DCMAKE_BUILD_TYPE=Release
- run: echo /opt/coverity/latest/bin >> "$GITHUB_PATH"
# The --compiler names must match those used by CMake.
Expand All @@ -53,7 +53,7 @@ jobs:
- run: cov-format-errors --text-output-style multiline --dir results --filesort --file "$PWD" --strip-path "$PWD" > cov-errors.txt
- run: cat cov-errors.txt
- run: count=$(grep -c '^$' cov-errors.txt) || true && echo "$(( $count / 2 ))"
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: fpga-runtime-for-opencl-${{ github.sha }}-coverity-${{ github.run_id }}
path: cov-errors.txt
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/fuzz-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Install PyYAML
run: pip install pyyaml
- name: Checkout runtime
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Build
run: |
mkdir -p build/fuzz_testing
Expand All @@ -60,7 +60,7 @@ jobs:
run: |
cat build/fuzz_testing/fuzz_testing/results/results.yml
- name: Upload results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: fpga-runtime-for-opencl-${{ github.sha }}-fuzz-test-results-${{ github.run_id }}
path: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tsan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

steps:
- name: checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: query distribution
run: cat /etc/os-release
Expand All @@ -85,7 +85,7 @@ jobs:
ctest -V
- name: tsan result
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: tsan-report
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

steps:
- name: checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

# See Git Glossary for pathspec patterns
# https://git-scm.com/docs/gitglossary#Documentation/gitglossary.txt-aiddefpathspecapathspec
Expand Down

0 comments on commit 124f56b

Please sign in to comment.