feat: Greeting 페이지 퍼블리싱 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tekiter
reviewed
Jul 24, 2023
apps/web/src/app/page.tsx
Outdated
Comment on lines
16
to
31
| <div className='relative h-[600vh]'> | ||
| <div className='absolute inset-0'> | ||
| <m.div | ||
| className='sticky top-0 h-[100vh] pt-[5rem] flex justify-center items-center' | ||
| initial={{ opacity: 0 }} | ||
| whileInView={{ opacity: 1 }} | ||
| viewport={{ once: true }} | ||
| transition={{ delay: 0.5 }} | ||
| > | ||
| <MakersLogo3D className='h-[25rem] w-[25rem] opacity-50' /> | ||
| </m.div> | ||
| </div> | ||
| <div className='absolute inset-0'> | ||
| <GreetingSection /> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
p3; 이 부분 모아서 ___Section 컴포넌트로 만들면 좋을 것 같아!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeting페이지를 애니메이션을 포함하여 퍼블리싱 하였습니다.