feat: greeting 문구별 애니메이션 추가 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tekiter
reviewed
Jul 25, 2023
Comment on lines
+35
to
+38
| <div className='pl-[4rem] py-[2.4rem] flex flex-col border-b border-solid border-white'> | ||
| <Title type='official' /> | ||
| <Description type='official' /> | ||
| </div> |
There was a problem hiding this comment.
p2; Description과 Title이 3개의 제품을 설명하는 3개의 일을 하고 있어요. 그런데 정작 레이아웃 코드의 중복 제거는 하고 있지 못해요.
또한 만약에 제품이 추가되면 <ProductSection>, <Title>, <Description> 을 모두 수정해야 해요.
만약 각 제품 설명은 따로 컴포넌트로 제작하고, 이 부분을 레이아웃 컴포넌트화 시켜서 children으로 받게 하면 이러한 문제를 해결할 수 있어요.
중복이 효과적으로 제거되면서도, 새로운 제품이 추가되었을 때 <ProductSection> 컴포넌트만 수정해도 되게 되어요.
EX)
<DescriptionLayout title="SOPT 공식 홈페이지" link="https://www.sopt.org/" iconClassName="fill-sub-yellow" keyword="OFFICIAL\n여러줄">
<SoptOfficialDescription />
</DescriptionLayout>There was a problem hiding this comment.
해당 부분은 product 영역인데, 현재 브랜치와 머지하는 과정에서 중간 과정이 딸려온 것 같습니다!
productSection 퍼블리싱 PR 에서 이 사항 반영해서 올리도록 할게요!!
|
p2; 위쪽에 공간이 충분함에도, 화면 높이가 조금만 작아져도 잘리는 문제가 있어요. 글자 그룹의 위치를 화면의 가운데로 맞춰주면 좋을 것 같아요. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-07-26.012052.mp4