Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installer): handle mpifort invoking f95 #724

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

rouson
Copy link
Member

@rouson rouson commented Nov 30, 2020

coverage on master
Codecov branch

Summary of changes

Updated the installation scripts to allow for mpifort invoking gfortran via f95.

Rationale for changes

On Lubuntu 20.04, sudo apt install mpich results in mpifort -show returning a command that starts with f95 instead of gfortran, which previously caused the installer to fail to recognize that mpifort wraps gfortran.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

@rouson rouson merged commit 5c4bd62 into main Nov 30, 2020
@rouson rouson deleted the update-installer branch November 30, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant