Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending data to self. #786

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix sending data to self. #786

merged 1 commit into from
Oct 11, 2024

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Oct 2, 2024

coverage on master
Codecov branch

Summary of changes

Correctly copy data when sending to this_image.

Rationale for changes

Sending data to this_image() lead to doing a memmove even when that was unsuitable, because size, rank, type, a.s.o. did not match. This patch directs all data sends to the convert routine, which does scalar to array and type/kind conversion correctly.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

that was unsuitable, because size, rank, type, a.s.o. did not
match. This patch directs all data sends to the convert
routine, which does scalar to array and type/kind conversion
correctly.
@vehre vehre requested a review from rouson October 8, 2024 12:04
@zbeekman
Copy link
Collaborator

zbeekman commented Oct 8, 2024

LGTM FWIW

Copy link
Collaborator

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit 1243b17 into main Oct 11, 2024
4 checks passed
@rouson rouson deleted the vehre/issue-783-fix-copy-self branch October 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants