Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print spacemesh wallet address #67

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Print spacemesh wallet address #67

merged 7 commits into from
Jul 14, 2023

Conversation

lrettig
Copy link
Member

@lrettig lrettig commented Jul 14, 2023

Closes #38

@lrettig lrettig requested review from noamnelke and fasmat July 14, 2023 10:28
noamnelke
noamnelke approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@noamnelke noamnelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lrettig
Copy link
Member Author

lrettig commented Jul 14, 2023

I checked that Smapp produces the same address from the same wallet file and mnemonic.

@lrettig lrettig requested a review from noamnelke July 14, 2023 10:57
@lrettig
Copy link
Member Author

lrettig commented Jul 14, 2023

@noamnelke added tests and HRP support, please check again

@lrettig lrettig requested a review from dshulyak July 14, 2023 11:02
@lrettig lrettig merged commit a1e889a into develop Jul 14, 2023
4 checks passed
@lrettig lrettig deleted the print-address branch July 14, 2023 11:06
This was referenced Aug 3, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamnelke noamnelke noamnelke approved these changes

@dshulyak dshulyak dshulyak approved these changes

@fasmat fasmat Awaiting requested review from fasmat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spacemesh wallet address format
3 participants
@lrettig @noamnelke @dshulyak