Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.2 cause Segmentation fault on MRI 2.0.0-p451 #1097

Closed
PikachuEXE opened this issue May 13, 2014 · 15 comments
Closed

1.6.2 cause Segmentation fault on MRI 2.0.0-p451 #1097

PikachuEXE opened this issue May 13, 2014 · 15 comments
Labels
topic/memory Segfaults, memory leaks, valgrind testing, etc.

Comments

@PikachuEXE
Copy link

http://pastebin.com/GHDE31WU

@knu
Copy link
Member

knu commented May 13, 2014

What are the steps to reproduce this?

@PikachuEXE
Copy link
Author

I bundle update on a rails app (rails 4.0.5)
Then rails c or foreman start cause this error

@knu
Copy link
Member

knu commented May 13, 2014

You may as well provide an output of bundle exec nokogiri --version, but in any case I'm not sure if we can investigate any further from the output above.

How is it like when running it with ruby 2.0.0-p481 or 2.1.2?

@PikachuEXE
Copy link
Author

bundle exec nokogiri --version still cause Segmentation fault
I don't have 2.0.0-p481 yet (RVM)

2.1.2 also cannot finish bundle install due to cldwalker/debugger#125

@mrkn
Copy link

mrkn commented May 13, 2014

This problem is also occurred on ruby 2.0.0-p481.

The cause is this commit c98745d, I think.

@knu
Copy link
Member

knu commented May 13, 2014

I would like the output produced by the following commands for further investigation:

# adjust "gem" below as necessary, like "bundle exec gem"
otool -L `gem which nokogiri/nokogiri`
grep -E 'LIBPATH|[Ff]ramework' $(dirname `gem which nokogiri`)/../ext/nokogiri/Makefile

@knu
Copy link
Member

knu commented May 13, 2014

I'm yet to figure out how c98745d could cause the problem, but anyway I've put a gem for testing I want you guys to try out.

gem install --source https://gems.idaemons.org/ nokogiri -v1.6.2.1.test1

This version is from the simplify_static branch which includes a rollback of c98745d.

@dodontommy
Copy link

+1 seg fault on ruby 2.0.0p353

@dahbearz
Copy link

The test branch gets me past the segfault.

@flavorjones
Copy link
Member

@PikachuEXE, can you confirm this fix in your case?
On May 13, 2014 9:42 PM, "Peter" notifications@github.com wrote:

The test branch gets me pas the segfault.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1097#issuecomment-43002588
.

@flavorjones
Copy link
Member

Trying to cut 1.6.2.1 in the next hour. Any updates from the OP would be very meaningful.

@mrkn
Copy link

mrkn commented May 14, 2014

The problem is fixed on 1.6.2.1.test1.

@flavorjones
Copy link
Member

OK, will merge this onto master and release as part of 1.6.2.1.

@flavorjones
Copy link
Member

1.6.2.1 released. Reopen if you still have issues.

@PikachuEXE
Copy link
Author

Sorry I was sleeping (different time zone)
Tested on 2.0.0p451 and 2.1.2 with nokogiri --version without error
Tested on 2.0.0p451 with bundle exec nokogiri --version without error
Version: 1.6.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/memory Segfaults, memory leaks, valgrind testing, etc.
Projects
None yet
Development

No branches or pull requests

6 participants