Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use have_header() to check for the existence of iconv.h #1218

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Use have_header() to check for the existence of iconv.h #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/nokogiri/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,10 @@ def install
]
end
else
if darwin_p && !File.exist?('/usr/include/iconv.h')
if darwin_p && !have_header('iconv.h')
abort <<'EOM'.chomp
-----
The file "/usr/include/iconv.h" is missing in your build environment,
The file "iconv.h" is missing in your build environment,
which means you haven't installed Xcode Command Line Tools properly.

To install Command Line Tools, try running `xcode-select --install` on
Expand Down