Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config so signing can be completely avoided. #6

Closed
wants to merge 2 commits into from
Closed

Add config so signing can be completely avoided. #6

wants to merge 2 commits into from

Conversation

leeovery
Copy link

Default is that signature validation will occur unless config 'is_signed' is set to false. Tests added and checked.

…ature validation will occur unless config 'is_signed' is set to false. Tests added and checked.
@freekmurze
Copy link
Member

Thanks for your work. I don't want a config option for this. Checking if the signature exist should be moved to the signer, so people that want to disable the signing can just return true from the signer.

@leeovery
Copy link
Author

leeovery commented Jun 19, 2019 via email

@leeovery
Copy link
Author

Started again with fresh PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants