Skip to content

Commit

Permalink
Viewer Exports Update (#2903)
Browse files Browse the repository at this point in the history
* Updated viewer type exports. Added missing types and removed tVector3 and Box3 from three

* Updated import source for Vector3

* Updated viewer-sandbox imports
  • Loading branch information
AlexandruPopovici authored Sep 23, 2024
1 parent 2f8efea commit e430e55
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 26 deletions.
2 changes: 1 addition & 1 deletion packages/frontend-2/components/viewer/gendo/Item.vue
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ import {
ArrowDownTrayIcon
} from '@heroicons/vue/24/outline'
import { useCameraUtilities } from '~/lib/viewer/composables/ui'
import type { Vector3 } from '@speckle/viewer'
import type { Vector3 } from 'three'
const props = defineProps<{
renderRequest: GendoAiRender
Expand Down
10 changes: 2 additions & 8 deletions packages/viewer-sandbox/src/Extensions/CameraPlanes.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import {
CameraController,
Extension,
GeometryType,
IViewer,
Vector3
} from '@speckle/viewer'
import { PerspectiveCamera } from 'three'
import { CameraController, Extension, GeometryType, IViewer } from '@speckle/viewer'
import { PerspectiveCamera, Vector3 } from 'three'

export class CameraPlanes extends Extension {
private camerController: CameraController
Expand Down
10 changes: 2 additions & 8 deletions packages/viewer-sandbox/src/Extensions/ExtendedSelection.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import { UpdateFlags } from '@speckle/viewer'
import {
Box3,
ObjectLayers,
SelectionEvent,
SelectionExtension,
Vector3
} from '@speckle/viewer'
import { Object3D } from 'three'
import { ObjectLayers, SelectionEvent, SelectionExtension } from '@speckle/viewer'
import { Object3D, Vector3, Box3 } from 'three'
import { TransformControls } from 'three/examples/jsm/controls/TransformControls'

export class ExtendedSelection extends SelectionExtension {
Expand Down
3 changes: 2 additions & 1 deletion packages/viewer-sandbox/src/Extensions/RotateCamera.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Vector3, Extension, IViewer, CameraController } from '@speckle/viewer'
import { Extension, IViewer, CameraController } from '@speckle/viewer'
import { Vector3 } from 'three'

export class RotateCamera extends Extension {
get inject() {
Expand Down
6 changes: 2 additions & 4 deletions packages/viewer-sandbox/src/Sandbox.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Box3, SectionTool, SpeckleStandardMaterial, TreeNode } from '@speckle/viewer'
import { SectionTool, SpeckleStandardMaterial, TreeNode } from '@speckle/viewer'
import {
CanonicalView,
Viewer,
Expand Down Expand Up @@ -32,12 +32,10 @@ import Mild2 from '../assets/hdri/Mild2.png'
import Sharp from '../assets/hdri/Sharp.png'
import Bright from '../assets/hdri/Bright.png'

import { Euler, Vector3 } from 'three'
import { Euler, Vector3, Box3, Color } from 'three'
import { GeometryType } from '@speckle/viewer'
import { MeshBatch } from '@speckle/viewer'

import { Color } from 'three'

export default class Sandbox {
private viewer: Viewer
private pane: Pane
Expand Down
14 changes: 10 additions & 4 deletions packages/viewer/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import type {
} from './modules/queries/Query.js'
import { type Utils } from './modules/Utils.js'
import { BatchObject } from './modules/batching/BatchObject.js'
import { Box3, Vector3 } from 'three'
import {
type MeasurementOptions,
MeasurementType,
Expand Down Expand Up @@ -64,7 +63,7 @@ import { Loader, LoaderEvent } from './modules/loaders/Loader.js'
import { SpeckleLoader } from './modules/loaders/Speckle/SpeckleLoader.js'
import { ObjLoader } from './modules/loaders/OBJ/ObjLoader.js'
import { LegacyViewer } from './modules/LegacyViewer.js'
import { SpeckleType } from './modules/loaders/GeometryConverter.js'
import { GeometryConverter, SpeckleType } from './modules/loaders/GeometryConverter.js'
import Input, { InputEvent, InputEventPayload } from './modules/input/Input.js'
import { GeometryType } from './modules/batching/Batch.js'
import { MeshBatch } from './modules/batching/MeshBatch.js'
Expand All @@ -78,6 +77,10 @@ import { Assets } from './modules/Assets.js'
import { SpecklePass } from './modules/pipeline/SpecklePass.js'
import { InstancedBatchObject } from './modules/batching/InstancedBatchObject.js'
import { HybridCameraController } from './modules/extensions/HybridCameraController.js'
import SpeckleBasicMaterial from './modules/materials/SpeckleBasicMaterial.js'
import LineBatch from './modules/batching/LineBatch.js'
import { PointBatch } from './modules/batching/PointBatch.js'
import TextBatch from './modules/batching/TextBatch.js'

export {
Viewer,
Expand All @@ -88,8 +91,6 @@ export {
World,
BatchObject,
InstancedBatchObject,
Box3,
Vector3,
WorldTree,
VisualDiffMode,
MeasurementType,
Expand All @@ -105,6 +106,7 @@ export {
ExplodeExtension,
DiffExtension,
Loader,
GeometryConverter,
SpeckleLoader,
ObjLoader,
LoaderEvent,
Expand All @@ -115,7 +117,11 @@ export {
ObjectLayers,
GeometryType,
MeshBatch,
LineBatch,
PointBatch,
TextBatch,
SpeckleStandardMaterial,
SpeckleBasicMaterial,
SpeckleTextMaterial,
SpeckleText,
NodeRenderView,
Expand Down

0 comments on commit e430e55

Please sign in to comment.