Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1611 Camera control fixes and improvements #1616

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Adressed issue #1611

Changes:

  • When selecting a canonical view, the camera target is always reset relative to the scene's extents Canonical Views don't reset target #1590
  • loadObject and loadObjectAsync now have an extra optional zoomToObject parameter which tells the camera to focus on the loaded object or not. Defaults to true
  • Selecting custom views will automatically re-enable camera rotations, if previously disabled by orthographic canonical views
  • Improved, camera behavior when switching from perspective to orthographic and back. There is still an issue with not matching orthographic size (zoom) with perspective distance when switching back and forth.

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…g in in orthographic mode, then switching to perspective does not yield the correct camera distance, especially when the controls target is off model
@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Jun 9, 2023
@AlexandruPopovici AlexandruPopovici self-assigned this Jun 9, 2023
@AlexandruPopovici AlexandruPopovici merged commit a52bb75 into main Jun 16, 2023
@AlexandruPopovici AlexandruPopovici deleted the alex/#1611 branch June 16, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants