feat(civil3d): adds all properties for sites, catchments, surfaces, and network parts #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #301 +/- ##
=====================================
Coverage 8.29% 8.29%
=====================================
Files 244 244
Lines 4882 4882
Branches 569 569
=====================================
Hits 405 405
Misses 4460 4460
Partials 17 17 ☔ View full report in Codecov by Sentry. |
…for-all-civil3d-entities
…vil3d-entities' of https://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-587-validate-properties-extracted-for-all-civil3d-entities
clairekuang
changed the title
|
Some of these look like caches as they're made using a dictionary and are scoped. I would probably name them that way. |
…for-all-civil3d-entities
…vil3d-entities' of https://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-587-validate-properties-extracted-for-all-civil3d-entities
…for-all-civil3d-entities
adamhathcock
approved these changes
Oct 14, 2024
clairekuang
deleted the
claire/cnx-587-validate-properties-extracted-for-all-civil3d-entities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all class and general properties for sites, catchments, surfaces, and network parts.
Also includes CatchmentGroups as
GroupProxiesof any catchment sent, andNetworkasGroupProxycontaining part ids.