Added support for IReadOnlyList deserialization #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
changed the title
gjedlicska
approved these changes
Jun 17, 2024
JR-Morgan
force-pushed
the
jrm/ireadonlylist-fix
branch
from
b5ed3c8
to
8a920f0
Compare
adamhathcock
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3451 introduced an issue where we were successfully serializing, but not successfully deserializing
IReadOnlyListproperties.This somehow got through my round of testing.... my bad! but thanks @gjedlicska for spotting this while 2.20 is still in wip! 🙌
In This PR
IListandIReadOnlyListtyped propertiesObjects.Teststo test that object model properties are one of the types supported by both our serializer and Deserializer (hard coded right now). Hopefully this will help ensure we never introduce this type of issue again.