Fix time indices for representative temporal blocks #1015
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sentative temporal structure
…slices" This reverts commit 1c31c02.
only prune the dynamic time slices for unit_state_transition prune first dynamic time slice only for unit with representative temporal blocks prune dynamic time slice by temp parameter
remove unused function
remove wrong pilot implementation
manuelma
reviewed
May 20, 2024
| # the model can't find a mapping to representative blocks for the outside time indices. | ||
| if !(explicit_representative_temporal_block(temporal_block=blk)) || tb in time_slice( | ||
| m; temporal_block=members(blk) | ||
| ) |
There was a problem hiding this comment.
This will damage performance.
manuelma
reviewed
May 20, 2024
src/variables/variable_common.jl
Outdated
| merge!(vars, Dict(ind => coeff * vars[ref_ind] for (ind, (ref_ind, coeff)) in ind_map)) | ||
| # A ref_ind may not be covered by keys(vars) unless | ||
| # the ind_map is carefully designed in specific variable adding functions. | ||
| merge!(vars, Dict(ind => coeff * vars[ref_ind] for (ind, (ref_ind, coeff)) in ind_map if haskey(vars, ref_ind))) |
There was a problem hiding this comment.
This haskey introduce an extra lookup for every iteration of the comprehension and might also damage performance.
There was a problem hiding this comment.
Thanks! The haskey check now goes outside the iteration (commit 2cefffa).
|
@nnhjy thanks a lot for this, seems to be coming along nicely. Perhaps you can describe in more detail the issue this is trying to solve? Also if you need help or if you want someone to review it before you merge it please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A perhaps provisional fix for the cases where we need representative temporal blocks and constraints concerning unit state transitions.
Fixes # (issue)
Checklist before merging