fix: Honor Package level renames in v2 yaml config #2001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following the docs for renames for
pkg
scoped renames, the renames were not applying. This is my first look into the sqlc config, but it looked like things were just not plumbed through.I just adds setting the renames from the yaml parse. In the combine settings I made sure to assign the renames from the pkg (the global was already set). This change does make pkg renames override global ones.
For unit testing, I noticed all the
endtoend/testdata
use a v1 config. Instead of adding more vectors to that to also dov2
directories, what if we just added asqlc.v1.yaml
andsqlc.v2.yaml
to each directory and run it twice? Or something of that nature to test v2 configs? At present this is not tested aside from some manual checking.