It is with sincere frustration that I remove this trailing comma from…

… an attribute definition. For some reason, this particular autofix will cause intermittent build failures and I can't figure out why
standardrb · Jun 24, 2024 · de955ab · de955ab
1 parent 3a27dcc
commit de955ab
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/test/fixture/cli/autocorrectable-bad.rb b/test/fixture/cli/autocorrectable-bad.rb
@@ -18,7 +18,7 @@ class Something
 
     alias do_more_stuff do_stuff
 
-  attr_reader :foo,
+  attr_reader :foo
 
     def do_stuff( a:,b:,c: )
 	maths_and_stuff = 4 +

diff --git a/test/fixture/cli/autocorrectable-good.rb b/test/fixture/cli/autocorrectable-good.rb
@@ -16,6 +16,7 @@ class Something
   alias_method :do_more_stuff, :do_stuff
 
   attr_reader :foo
+
   def do_stuff(a:, b:, c:)
     maths_and_stuff = 4 +
       5 +

diff --git a/test/standard/cli_test.rb b/test/standard/cli_test.rb
@@ -8,9 +8,11 @@ def test_autocorrectable
 
     FileUtils.cp("test/fixture/cli/autocorrectable-bad.rb", "tmp/cli_test/subject.rb")
 
-    exit_code = Standard::Cli.new(["tmp/cli_test/subject.rb", "--fix"]).run
+    do_with_fake_io do
+      exit_code = Standard::Cli.new(["tmp/cli_test/subject.rb", "--fix"]).run
+      assert_equal 0, exit_code
+    end
 
-    assert_equal 0, exit_code
     assert_equal File.read("test/fixture/cli/autocorrectable-good.rb"), File.read("tmp/cli_test/subject.rb")
   end