LS: Fix hover definition lookup logic #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orizi
approved these changes
May 22, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mkaput)
Since ba74ab1 the hover logic wrongly tried to find definition lookup item by inspecting originating location within `get_definition_location`. The bug was introduced by making an attempt to share the definition lookup logic with _goto definition_, where actually both features need different results. commit-id:f3e136e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ba74ab1 the hover logic wrongly
tried to find definition lookup item by inspecting originating location
within
get_definition_location. The bug was introduced by making anattempt to share the definition lookup logic with goto definition,
where actually both features need different results.
Stack:
test_file_test!for hover tests #5605This change is