Added cairo icon to ensure all .cairo extensions are recognisable #5665
Conversation
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, all commit messages.
Reviewable status: 3 of 5 files reviewed, 4 unresolved discussions (waiting on @Utilitycoder)
a discussion (no related file):
Thanks for this PR! I want to test this manually, so I'll unblock this comment when I'll do this 😃
vscode-cairo/package.json line 37 at r1 (raw file):
"iconThemes": [ { "id": "cairo-icon-theme",
This looks weird to me. How does this play with external file icon themes?
- Say, user has installed vscode-icons (https://marketplace.visualstudio.com/items?itemName=vscode-icons-team.vscode-icons), how does this change affects the user?
- What if custom icon theme is defining one for Cairo? Which icon wins?
I took a look at VSCode docs, and it looks like there is a more appropriate approach: https://code.visualstudio.com/api/extension-guides/file-icon-theme#language-default-icons wdyt?
vscode-cairo/package.json line 141 at r1 (raw file):
"prettier": "3.2.4", "typescript": "^5.3.3", "vscode": "^1.1.37"
Why do you need this line to be added?
vscode-cairo/icons/cairo-icon.png line 0 at r1 (raw file):
What has changed here? I cannot spot a difference. Would it be possible to revert this?
There was a problem hiding this comment.
Reviewed 2 of 5 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Utilitycoder)
vscode-cairo/images/icon.png line 0 at r1 (raw file):
VSCode docs say that it's preferable to use SVG (https://code.visualstudio.com/api/extension-guides/file-icon-theme#adding-a-new-file-icon-theme, first sentence). I'll ask Starkware ppl for it.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Utilitycoder)
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 5 unresolved discussions (waiting on @Utilitycoder)
vscode-cairo/images/icon.png line at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
VSCode docs say that it's preferable to use SVG (https://code.visualstudio.com/api/extension-guides/file-icon-theme#adding-a-new-file-icon-theme, first sentence). I'll ask Starkware ppl for it.
https://starkware.co/media-kit/ you can get it here :)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @Utilitycoder)
There was a problem hiding this comment.
Reviewed 4 of 5 files at r3.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @Utilitycoder)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r4.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @Utilitycoder)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @Utilitycoder)
There was a problem hiding this comment.
i did some cleanups myself
thanks for contribution! ❤️❤️❤️❤️❤️
Reviewed 1 of 2 files at r4, 5 of 5 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Utilitycoder)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This closes issue #5626
This change is