Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report inference diagnostics if there are other diagnostics. #5930

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ilyalesokhin-starkware
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware commented Jul 2, 2024

This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor Author

crates/cairo-lang-semantic/src/items/tests/early_conform line 1140 at r1 (raw file):

                                          ^*****^

error: Type annotations needed. Failed to infer ?0.

I wanted to skip only those errors; I'll try a different approach.

Code quote:

error: Type annotations needed. Failed to infer ?0.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 10 files at r1, all commit messages.
Reviewable status: 8 of 10 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-semantic/src/diagnostic_test_data/tests line 180 at r1 (raw file):

             ^******^

error: Mismatched types. The type `core::bool` cannot be created from a numeric literal.

This seemed like a good diag


crates/cairo-lang-semantic/src/expr/test_data/function_call line 181 at r1 (raw file):


error: Trait has no implementation in context: core::traits::Add::<test::MyStruct>.
 --> lib.cairo:13:5

Seems like a regression as well.

Copy link
Contributor Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 11 files reviewed, 3 unresolved discussions (waiting on @orizi)


crates/cairo-lang-semantic/src/diagnostic_test_data/tests line 180 at r1 (raw file):

Previously, orizi wrote…

This seemed like a good diag

Done.


crates/cairo-lang-semantic/src/expr/test_data/function_call line 181 at r1 (raw file):

Previously, orizi wrote…

Seems like a regression as well.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Jul 2, 2024
Merged via the queue into dev-v2.7.0 with commit a454b32 Jul 2, 2024
42 of 43 checks passed
@orizi orizi deleted the ilya/skip_diag branch July 3, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants