Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS: Add a command to inspect analyzed crates #5987

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

mkaput
Copy link
Contributor

@mkaput mkaput commented Jul 9, 2024

This change is Reviewable

@mkaput mkaput requested a review from Draggu as a code owner July 9, 2024 15:36
@mkaput mkaput requested a review from orizi July 9, 2024 15:38
@mkaput mkaput force-pushed the spr/main/26737288 branch 2 times, most recently from 58b1606 to 276d1d9 Compare July 9, 2024 17:02
@mkaput mkaput changed the base branch from spr/main/a865f380 to main July 9, 2024 18:32
@mkaput mkaput changed the base branch from main to spr/main/a4f82b7a July 9, 2024 18:33
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 16 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Draggu and @mkaput)


crates/cairo-lang-language-server/src/lang/inspect/crates.rs line 27 at r2 (raw file):

}

fn inspect_crate(cr: Crate) -> String {

doc.


crates/cairo-lang-language-server/src/lang/inspect/crates.rs line 39 at r2 (raw file):

}

fn indent(text: String) -> String {

there's an existing crate for this function:
indent::indent_by.


crates/cairo-lang-language-server/tests/e2e/support/normalize.rs line 12 at r2 (raw file):

    fn inner(fixture: &Fixture, data: String) -> String {
        normalize_well_known_paths(fixture, normalize_paths(data))
    }

why use an inner function?

Code quote:

    fn inner(fixture: &Fixture, data: String) -> String {
        normalize_well_known_paths(fixture, normalize_paths(data))
    }

@mkaput mkaput changed the base branch from spr/main/a4f82b7a to spr/main/a865f380 July 10, 2024 07:52
Copy link
Contributor Author

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 12 of 18 files reviewed, 3 unresolved discussions (waiting on @Draggu and @orizi)


crates/cairo-lang-language-server/src/lang/inspect/crates.rs line 27 at r2 (raw file):

Previously, orizi wrote…

doc.

Done.


crates/cairo-lang-language-server/src/lang/inspect/crates.rs line 39 at r2 (raw file):

Previously, orizi wrote…

there's an existing crate for this function:
indent::indent_by.

Done.


crates/cairo-lang-language-server/tests/e2e/support/normalize.rs line 12 at r2 (raw file):

Previously, orizi wrote…

why use an inner function?

Ah, I applied the following pattern habitually, yet it's non-effective here. Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Draggu)

Copy link
Collaborator

@Draggu Draggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 16 files at r1, 3 of 6 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@mkaput mkaput changed the base branch from spr/main/a865f380 to main July 10, 2024 11:04
@mkaput mkaput enabled auto-merge July 10, 2024 11:09
@mkaput mkaput added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit b5c5429 Jul 10, 2024
86 of 87 checks passed
@mkaput mkaput deleted the spr/main/26737288 branch July 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants