Added more proper code mappings in starknet plugins. #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2024
Merged
mkaput
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
orizi
force-pushed
the
pr/orizi/updates/e1b0c9fb
branch
from
51d56e4
to
834791b
Compare
orizi
force-pushed
the
pr/orizi/updates/1102d2a4
branch
from
2c814f8
to
3d60a56
Compare
orizi
force-pushed
the
pr/orizi/updates/1102d2a4
branch
from
3d60a56
to
8080ed0
Compare
orizi
force-pushed
the
pr/orizi/updates/9e8383ea
branch
from
cb2a0ff
to
f334f07
Compare
orizi
force-pushed
the
pr/orizi/updates/1102d2a4
branch
from
8080ed0
to
6b70617
Compare
mkaput
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
Refactored a bit on the way. commit-id:1102d2a4
orizi
force-pushed
the
pr/orizi/updates/1102d2a4
branch
from
6b70617
to
3bfb75e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored a bit on the way.
Stack:
defsplugins files to be based on external files. #6225This change is