Updated sierra ap-change finding to be based on final lowering.

[orizi]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-sierra-generator/src/ap_change.rs line 20 at r1 (raw file):

    function_id: ConcreteFunctionWithBodyId,
) -> Maybe<SierraApChange> {
    // The implementation of get_ap_change() may call this function recursively. To guarantee no

Maybe we should just add cycle handling to the function?

Code quote:

 // salsa query cycles are created, we first verify that there are no cycles.

[ilyalesokhin-starkware]

Reviewed 3 of 5 files at r1.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi)

[orizi]

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-sierra-generator/src/ap_change.rs line 20 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Maybe we should just add cycle handling to the function?

if we do that - this won't be the function that is actually the entry into the salsa-cycle - it would probably be a random function that generates the sierra code.

[ilyalesokhin-starkware]

Reviewed 2 of 5 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @orizi)

[mkaput]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @piotmag769)