Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sierra generation external stack based. #6303

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 28, 2024

This change is Reviewable

@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra-generator/src/block_generator.rs line 111 at r1 (raw file):

) -> Maybe<Vec<StatementWithLocation>> {
    let mut block_gen_stack = vec![BlockGenStackElement::Block(BlockId::root())];
    while let Some(pe) = block_gen_stack.pop() {

what does pe stand for?
Can you rename it?

Code quote:

pe

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra-generator/src/block_generator.rs line 111 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

what does pe stand for?
Can you rename it?

Done.

@orizi orizi force-pushed the orizi/no-recursion-sierra-gen branch from 62c45ba to e1c7ff8 Compare August 28, 2024 12:58
@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra-generator/src/block_generator.rs line 104 at r2 (raw file):

}

/// Generates Sierra statements for a given for the function from the given [ExprGeneratorContext].

Suggestion:

Generates Sierra statements for a function from the given [ExprGeneratorContext].

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi force-pushed the orizi/no-recursion-sierra-gen branch from e1c7ff8 to bddd6c2 Compare August 28, 2024 14:54
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra-generator/src/block_generator.rs line 104 at r2 (raw file):

}

/// Generates Sierra statements for a given for the function from the given [ExprGeneratorContext].

Done.

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit be5bc2a Aug 29, 2024
44 checks passed
@orizi orizi deleted the orizi/no-recursion-sierra-gen branch September 5, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Stack overflow on 2.6.3 with dynamic layout of STARK verifier in Cairo1
2 participants